docs(README): when patching global context, patch TextDecoder and TextEncoder too #1774
+12
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After following the README on patching the global context, node-fetch fails to me in jest jsdom environment on node v16.16.0 with following error:
That's probably because node-fetch in https://github.com/node-fetch/node-fetch/blob/main/src/body.js#L159 refers to
TextDecoder
using a global reference, which doesn't exist in my environment.Changes
In recommended script in README that patches the global context, add
TextDecoder
andTextEncoder
to the global context too.I also removed a few unnecessary imports from it that weren't used at all.
Additional information